Skip to content

allow rbind for integer64 and character/complex/vector#5874

Merged
MichaelChirico merged 17 commits intomasterfrom
rbind_integer64
Sep 8, 2024
Merged

allow rbind for integer64 and character/complex/vector#5874
MichaelChirico merged 17 commits intomasterfrom
rbind_integer64

Conversation

@ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Jan 2, 2024 •
edited
Loading

Closes #5504

@codecov
Copy link

codecov bot commented Jan 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b60d10) 97.47% compared to head (f4e4563) 97.47%.
Report is 10 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5874   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          80       80           
  Lines       14831    14831           
=======================================
  Hits        14457    14457           
  Misses        374      374

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ben-schwen ben-schwen marked this pull request as ready for review January 3, 2024 00:04
@ben-schwen ben-schwen requested a review from mattdowle as a code owner January 3, 2024 00:04
@ben-schwen ben-schwen changed the title allow rbind for integer64 and character/complex allow rbind for integer64 and character/complex/vector Jan 4, 2024
@MichaelChirico MichaelChirico mentioned this pull request Jan 6, 2024
Draft
@MichaelChirico
Copy link
Member

MichaelChirico commented Sep 4, 2024

I thought this might be covered by #5446, but I confirm the issue in #5504 is still present on master.

Would you mind updating this PR?

@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Sep 4, 2024
@ben-schwen
Copy link
Member Author

ben-schwen commented Sep 4, 2024

Would you mind updating this PR?

Will do at the weekend

@github-actions
Copy link

github-actions bot commented Sep 8, 2024 •
edited
Loading

Comparison Plot

Generated via commit bdcfd2b

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 27 seconds

Time taken to run atime::atime_pkg on the tests: 6 minutes and 52 seconds

@MichaelChirico
Copy link
Member

MichaelChirico commented Sep 8, 2024 •
edited
Loading

Funny it took till now to find the issue with test 2265 re-attaching {bit64} incorrectly. It did not show up under cc(). But I did see that same error in a different context & shrugged it off. Now understood(ish) and fixed.

MichaelChirico
MichaelChirico approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@MichaelChirico MichaelChirico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why always using coerceAs() doesn't "just work" but switching broke a lot of tests; left for future exercise :)

@MichaelChirico MichaelChirico merged commit f0aaaf9 into master Sep 8, 2024
@MichaelChirico MichaelChirico deleted the rbind_integer64 branch September 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

@mattdowle mattdowle Awaiting requested review from mattdowle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

rbindlist internal error when binding integer64 + character columns

2 participants

@ben-schwen @MichaelChirico